Skip to content

Adjust template exportation#148

Merged
marcospassos merged 5 commits into
masterfrom
adjust-experience-query
Jul 16, 2026
Merged

Adjust template exportation#148
marcospassos merged 5 commits into
masterfrom
adjust-experience-query

Conversation

@denis-rossati

@denis-rossati denis-rossati commented Jul 16, 2026

Copy link
Copy Markdown
Member

Summary

This PR will remove the groupIdfrom the segmented content in the experience query.

It is necessary because this query is used to create the JSON template when running croct create template. But the presence of the group ID violates the template validation in commands such as the croct use template.json before sending them to the backend.

Other queries and commands doesn't seem to need this field, so it was harmlessly removed.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@denis-rossati denis-rossati self-assigned this Jul 16, 2026
@denis-rossati denis-rossati added the bug Something isn't working label Jul 16, 2026
@github-actions

Copy link
Copy Markdown

👋 @denis-rossati
Thanks for your contribution!
The approval and merge process is almost fully automated 🧙
Here's how it works:

  1. You open a new pull request
  2. Automated tests check the code
  3. Maintainers review the code
  4. Once approved, the PR is ready to merge.

👉 Omit the extended description
Please remove the commit body before merging the pull request.
Instead, include the pull request number in the title to provide the full context
about the change.

☝️ Lastly, the title for the commit will come from the pull request title. So please provide a descriptive title that summarizes the changes in 50 characters or less using the imperative mood.
Happy coding! 🎉

@pkg-pr-new

pkg-pr-new Bot commented Jul 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/croct@148

commit: 5f02e7c

@denis-rossati denis-rossati changed the title Adjust experience query Adjust template exportation Jul 16, 2026
Comment thread src/application/cli/command/template/create.ts Outdated
@marcospassos
marcospassos merged commit 09a2acd into master Jul 16, 2026
7 checks passed
@marcospassos
marcospassos deleted the adjust-experience-query branch July 16, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants